Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance kcl version info message using the vergen crate and bump kcl version to v0.4.6.3 #550

Merged
merged 1 commit into from
May 16, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 16, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

refactor: enhance kcl version info message using the vergen crate and bump kcl version to v0.4.6.3

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/version/build.rs
  • scripts/build-windows/kcl.go
  • internal/scripts/cli/kcl

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
  • Patch version info only for v0.4.x, all CLIs will be unified after v0.5.x.
  • Add git commit and platform showing in the version info

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the CLI label May 16, 2023
@Peefy Peefy added this to the v0.5.0 Release milestone May 16, 2023
@Peefy Peefy requested review from chai2010, NeverRaR, He1pa and zong-zhe May 16, 2023 07:48
@Peefy Peefy self-assigned this May 16, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 16, 2023

Pull Request Test Coverage Report for Build 4989255875

  • 2 of 11 (18.18%) changed or added relevant lines in 3 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-20.2%) to 67.779%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/cmd/src/lib.rs 0 1 0.0%
kclvm/version/src/lib.rs 1 9 11.11%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 4976255280: -20.2%
Covered Lines: 30489
Relevant Lines: 44983

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1742aec into kcl-lang:main May 16, 2023
@Peefy Peefy deleted the enhance-kcl-version-info branch May 16, 2023 11:00
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants